On Sun, Jan 14, 2018 at 11:51 AM, Jonathan Cameron <jic23@xxxxxxxxxx> wrote: > On Wed, 10 Jan 2018 12:01:07 +0100 > Javier Martinez Canillas <javier@xxxxxxxxxxxx> wrote: > >> Hello Jonathan, >> >> On Mon, Jan 1, 2018 at 10:53 AM, Jonathan Cameron <jic23@xxxxxxxxxx> wrote: >> >> [snip] >> >> > >> > I may well be missing some subtle detail of course having spent only a few >> > minute looking at this! >> > >> >> Your understanding is correct. This change has nothing to do with >> module autoloading. >> >> The .probe_new callback is only used to avoid requiring an I2C device >> ID table since the old .probe callback has a struct i2c_device_id as a >> parameter and so requires a table even in OF (or ACPI) only drivers. > > OK, then let us revisit this patch once we have an answer on your one > fixing the autoprobing more generally. Until we then we don't know > whether we need to add the i2c table in or not whether this suffices. > That's correct. If the driver is for a device that's OF-only (e.g: will never be used from a non-DT platform) then I don't think we should add a I2C table. Now, if Wolfram nacks my patch then we should add it as a workaround to have auto-loading working. > Jonathan > Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
