On Thu, 4 Jan 2018 21:49:07 +0530 venkat.prashanth2498@xxxxxxxxx wrote: > From: Venkat Prashanth B U <venkat.prashanth2498@xxxxxxxxx> > > This is a patch to the mcp4725.c file which > fixes the following coccinelle warning: > > WARNING: conversion to bool not needed here > > Signed-off-by: Venkat Prashanth B U <venkat.prashanth2498@xxxxxxxxx> > Version log belongs below the --- cut line. It is very useful when we are reviewing code, but not something we want to have in the git history for ever. Please send a V3 with that fixed. Jonathan > Changes since v1: > ----------------- > Instead of inadvertent removal of complete statement, only the > conversion to bool is removed. > --- > drivers/iio/dac/mcp4725.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/dac/mcp4725.c b/drivers/iio/dac/mcp4725.c > index afa856d..8b5aad4 100644 > --- a/drivers/iio/dac/mcp4725.c > +++ b/drivers/iio/dac/mcp4725.c > @@ -476,7 +476,7 @@ static int mcp4725_probe(struct i2c_client *client, > goto err_disable_vref_reg; > } > pd = (inbuf[0] >> 1) & 0x3; > - data->powerdown = pd > 0 ? true : false; > + data->powerdown = pd > 0; > data->powerdown_mode = pd ? pd - 1 : 2; /* largest resistor to gnd */ > data->dac_value = (inbuf[1] << 4) | (inbuf[2] >> 4); > if (data->id == MCP4726) -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
