> > On 2017-09-30 19:59, Jonathan Cameron wrote: > > > On Wed, 27 Sep 2017 08:52:54 +0200 > > > Martin Kepplinger <martink@xxxxxxxxx> wrote: > > > > > >> Am 25.09.2017 12:40 schrieb Harinath Nampally: > > >>> Improves code readability, no impact on functionality. > > >>> > > >>> Signed-off-by: Harinath Nampally <harinath922@xxxxxxxxx> > > >>> --- > > >> > > >> I'd prefer a shorter subject line here too, see patch 2/3 > > > > > > Agreed. I'm unconvinced the change helps. Perhaps that is > > > because I don't fully understand why you are making the change? > > > > > > > It's understandable for me. It simply uses "transient" and "ff_mt" in > > order to describe sets of device-registers instead of "rising" and > > "falling". That's more appropriate. I'd apply this if possible. > > > > Even though it should be clear after reading the data sheet, this > > particular issue sometimes gets confusing for people. Maybe a short > > descriptive comment, pointing to the data sheet, would make sense? > > > > With the addition of some description, this should be fine. Sure will do. Thanks, Harinath On Mon, Oct 2, 2017 at 6:35 AM, Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> wrote: > On Sun, 1 Oct 2017 20:10:49 +0200 > Martin Kepplinger <martink@xxxxxxxxx> wrote: > >> On 2017-09-30 19:59, Jonathan Cameron wrote: >> > On Wed, 27 Sep 2017 08:52:54 +0200 >> > Martin Kepplinger <martink@xxxxxxxxx> wrote: >> > >> >> Am 25.09.2017 12:40 schrieb Harinath Nampally: >> >>> Improves code readability, no impact on functionality. >> >>> >> >>> Signed-off-by: Harinath Nampally <harinath922@xxxxxxxxx> >> >>> --- >> >> >> >> I'd prefer a shorter subject line here too, see patch 2/3 >> > >> > Agreed. I'm unconvinced the change helps. Perhaps that is >> > because I don't fully understand why you are making the change? >> > >> >> It's understandable for me. It simply uses "transient" and "ff_mt" in >> order to describe sets of device-registers instead of "rising" and >> "falling". That's more appropriate. I'd apply this if possible. >> >> Even though it should be clear after reading the data sheet, this >> particular issue sometimes gets confusing for people. Maybe a short >> descriptive comment, pointing to the data sheet, would make sense? >> > > With the addition of some description, this should be fine. > > Thanks, > > Jonathan > >> martin >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-iio" in >> the body of a message to majordomo@xxxxxxxxxxxxxxx >> More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
