2017-10-01 2:32 GMT+09:00 Jonathan Cameron <jic23@xxxxxxxxxxxxxxxxxxxxx>: > On Sun, 30 Jul 2017 17:58:06 +0100 > Jonathan Cameron <jic23@xxxxxxxxxx> wrote: > >> On Mon, 31 Jul 2017 00:12:55 +0900 >> Akinobu Mita <akinobu.mita@xxxxxxxxx> wrote: >> >> > The ADS1015 device provides programmable comparator that can issue an >> > interrupt on the ALERT pin. This change adds the iio threshold event >> > support for that feature. >> > >> > The ADS1015 device only have a single config register which contains an >> > input multiplexer selection, comparator settings, and etc. So only a >> > single event channel can be enabled at a time. Also enabling both buffer >> > and event are prohibited for simplicity. >> > >> > Cc: Daniel Baluta <daniel.baluta@xxxxxxxxx> >> > Cc: Jonathan Cameron <jic23@xxxxxxxxxx> >> > Signed-off-by: Akinobu Mita <akinobu.mita@xxxxxxxxx> >> Very nice. I pretty much assumed there would be a locking problem in here >> but as far as I can see you got it spot on! >> >> This will obviously be waiting on the fixes to work their way through the >> fixes tree. >> >> I'm also happy with the rest of the series before this. >> >> Please give me a bump if it looks like I've lost this >> somehow (it's been known to happen if the cycle of getting >> changes back from the fixes tree takes too long) > > I've just been revisiting my patches to apply set and discovered I actually > took v2 of many if not all of these patches a week before this set was posted. > Could you sanity check the results currently in tree? I've already realized and sent an patch that was not included in v2. You have already added it to the fixes-togreg-post-rc1 branch of iio.git :) Please take a look at the email thread "[PATCH v2 11/11] iio: adc: ti-ads1015: add threshold event support". The patch "iio: adc: ti-ads1015: fix comparator polarity setting" is now added to Greg's staging-linus branch. So if the patch will be merged, everything will be fine. -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
