On 09/12/2017 09:53 AM, Daniel Baluta wrote: > Hi Himanshi, > > On Tue, Sep 12, 2017 at 1:43 AM, Himanshi Jain <himshijain.hj@xxxxxxxxx> wrote: >> Fixed IIO_DEVICE_ATTR_NAMED API to take name as a >> string instead of implicit conversion to string using >> preprocessors. Added double quotes around names in >> existing usage of IIO_DEVICE_ATTR_NAMED. > > Always use imperative mood in commit subject (Fix instead of Fixed). > > The subject should contain a tag, which describes the subsytem/files affected. > > I would split this patch into: > > 1) sysfs: iio: Introduce *_ATTR_NAMED > > and explain here why do we need __ATTR_NAMED and IIO_ATTR_NAMED > > 2) iio: Use new IIO_DEVICE_ATTR_NAMED API > > But of course, lets wait to see Lars and Jonathan's opinions. Fully agreed with what you wrote. -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
