On Fri, 26 May 2017 12:07:41 +0530 Arvind Yadav <arvind.yadav.cs@xxxxxxxxx> wrote: > clk_prepare_enable() can fail here and we must check its return value. > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@xxxxxxxxx> Straight forward looking so I've applied this to the togreg branch of iio.git and pushed it out as testing for the autobuilders to play with it. Thanks, Jonathan > --- > drivers/iio/adc/xilinx-xadc-core.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/xilinx-xadc-core.c b/drivers/iio/adc/xilinx-xadc-core.c > index 56cf590..4a60497 100644 > --- a/drivers/iio/adc/xilinx-xadc-core.c > +++ b/drivers/iio/adc/xilinx-xadc-core.c > @@ -1204,7 +1204,10 @@ static int xadc_probe(struct platform_device *pdev) > ret = PTR_ERR(xadc->clk); > goto err_free_samplerate_trigger; > } > - clk_prepare_enable(xadc->clk); > + > + ret = clk_prepare_enable(xadc->clk); > + if (ret) > + goto err_free_samplerate_trigger; > > ret = xadc->ops->setup(pdev, indio_dev, irq); > if (ret) -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html