> On 19/05/17 21:11, Lorenzo Bianconi wrote:
>>
>> Get rid of #ifdef CONFIG_PM by adding __maybe_unused macro to
>> st_lsm6dsx_suspend and st_lsm6dsx_resume function declarations
>>
>> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@xxxxxx>
>
> Why?
>
> I'm not against the change, but there should be some sort of
> explanation of why you are making it in the patch description.
>
> I'm going to hazard a guess it is because you can have CONFIG_PM
> without CONFIG_PM_SLEEP which in pm.h results in you still
> getting a warning as SET_SYSTEM_SLEEP_PM_OPS is stubbed out..
>
> A good reason, but should be stated here.
>
> Jonathan
>
>
>> ---
>> drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 6 ++----
>> 1 file changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
>> b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
>> index 1b53848cdfd8..b485540da89e 100644
>> --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
>> +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
>> @@ -732,8 +732,7 @@ int st_lsm6dsx_probe(struct device *dev, int irq, int
>> hw_id, const char *name,
>> }
>> EXPORT_SYMBOL(st_lsm6dsx_probe);
>> -#ifdef CONFIG_PM
>> -static int st_lsm6dsx_suspend(struct device *dev)
>> +static int __maybe_unused st_lsm6dsx_suspend(struct device *dev)
>> {
>> struct st_lsm6dsx_hw *hw = dev_get_drvdata(dev);
>> struct st_lsm6dsx_sensor *sensor;
>> @@ -757,7 +756,7 @@ static int st_lsm6dsx_suspend(struct device *dev)
>> return err;
>> }
>> -static int st_lsm6dsx_resume(struct device *dev)
>> +static int __maybe_unused st_lsm6dsx_resume(struct device *dev)
>> {
>> struct st_lsm6dsx_hw *hw = dev_get_drvdata(dev);
>> struct st_lsm6dsx_sensor *sensor;
>> @@ -778,7 +777,6 @@ static int st_lsm6dsx_resume(struct device *dev)
>> return err;
>> }
>> -#endif /* CONFIG_PM */
>> const struct dev_pm_ops st_lsm6dsx_pm_ops = {
>> SET_SYSTEM_SLEEP_PM_OPS(st_lsm6dsx_suspend, st_lsm6dsx_resume)
>>
>
Hi Jonathan,
Just to align st_lsm6dsx driver to what we have done in hts221. We
agreed __maybe_unused macro is becoming more common and is the
preferred choice now.
Regards,
Lorenzo
--
UNIX is Sexy: who | grep -i blonde | talk; cd ~; wine; talk; touch;
unzip; touch; strip; gasp; finger; gasp; mount; fsck; more; yes; gasp;
umount; make clean; sleep
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
