Re: [PATCH v3] iio: adc: Add support for TI ADC108S102 and ADC128S102

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 05, 2017 at 12:23:26PM +0200, Jan Kiszka wrote:
> >> +	} else {
> >> +		st->reg = devm_regulator_get(&spi->dev, "vref");
> >> +		if (IS_ERR(st->reg))
> >> +			return PTR_ERR(st->reg);
> > 
> > This should be an optional regulator and in case of ACPI you just don't
> > have it.
> 
> It's mandatory for this DT case, so I will not change that.

Well, it would be better if you don't need to deviate in the driver like
this. And it clearly is optional because in case of ACPI you don't need
it.

Not my call, though.
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux