Hi Lee,
>
> Hi Wei,
>
> On Sun, Apr 30, 2017 at 6:31 PM, Jonathan Cameron <jic23@xxxxxxxxxx>
> wrote:
> > On 27/04/17 16:14, Wei Yongjun wrote:
> >> From: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
> >>
> >> In case of error, the function devm_ioremap() returns NULL pointer not
> >> ERR_PTR(). Use devm_ioremap_resource() instead of devm_ioremap().
> >>
> >> Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
> > I'll be wanting a tested-by for this one.
> >
> > Thanks,
> >
> > Jonathan
> >> ---
> >> v1 -> v2: use devm_ioremap_resource()
> >> ---
>
>
> I tested your patch on i.mx28 and it causes probe failure. Here's dmesg
> output:
>
> [ 3.065959] mxs-lradc-adc mxs-lradc-adc: can't request region for
> resource [mem 0x80050000-0x80051fff]
> [ 3.075537] mxs-lradc-adc: probe of mxs-lradc-adc failed with error -16
It seems that mxs-lradc devices share memory regions, and devm_ioremap_resource
does not allow to share resources we should still use devm_ioremap().
Regards,
Yongjun Wei
��.n��������+%������w��{.n�����{��(��)�� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
