On 26 April 2017 01:49:58 GMT-07:00, Lee Jones <lee.jones@xxxxxxxxxx> wrote: >On Wed, 26 Apr 2017, Jonathan Cameron wrote: > >> On 25/04/17 04:36, Wei Yongjun wrote: >> > From: Wei Yongjun <weiyongjun1@xxxxxxxxxx> >> > >> > In case of error, the function devm_ioremap() returns NULL pointer >> > not ERR_PTR(). The IS_ERR() test in the return value check should >> > be replaced with NULL test. >> > >> > Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx> >> Acked-by: Jonathan Cameron <jic23@xxxxxxxxxx> >> >> Lee, do you want to pick this up? If not I'll scoop it up after the >merge >> window has unwound as a fix. Needs to be on top of the series: >> [PATCH v15 0/5] mxs-lradc: Split driver into MFD > >I'm inclined to agree with Dmitry: > >https://www.spinics.net/lists/linux-input/msg51061.html Agreed. Tidier fix > >> > --- >> > drivers/iio/adc/mxs-lradc-adc.c | 4 ++-- >> > 1 file changed, 2 insertions(+), 2 deletions(-) >> > >> > diff --git a/drivers/iio/adc/mxs-lradc-adc.c >b/drivers/iio/adc/mxs-lradc-adc.c >> > index b0c7d8e..493e2a2 100644 >> > --- a/drivers/iio/adc/mxs-lradc-adc.c >> > +++ b/drivers/iio/adc/mxs-lradc-adc.c >> > @@ -719,8 +719,8 @@ static int mxs_lradc_adc_probe(struct >platform_device *pdev) >> > >> > iores = platform_get_resource(pdev, IORESOURCE_MEM, 0); >> > adc->base = devm_ioremap(dev, iores->start, >resource_size(iores)); >> > - if (IS_ERR(adc->base)) >> > - return PTR_ERR(adc->base); >> > + if (!adc->base) >> > + return -ENOMEM; >> > >> > init_completion(&adc->completion); >> > spin_lock_init(&adc->lock); >> > >> -- Sent from my Android device with K-9 Mail. Please excuse my brevity. -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
