> > On Wed, 26 Apr 2017, weiyongjun (A) wrote: > > > > > > > On Wed, 26 Apr 2017, Jonathan Cameron wrote: > > > > > > > On 25/04/17 04:36, Wei Yongjun wrote: > > > > > From: Wei Yongjun <weiyongjun1@xxxxxxxxxx> > > > > > > > > > > In case of error, the function devm_ioremap() returns NULL pointer > > > > > not ERR_PTR(). The IS_ERR() test in the return value check should > > > > > be replaced with NULL test. > > > > > > > > > > Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx> > > > > Acked-by: Jonathan Cameron <jic23@xxxxxxxxxx> > > > > > > > > Lee, do you want to pick this up? If not I'll scoop it up after the merge > > > > window has unwound as a fix. Needs to be on top of the series: > > > > [PATCH v15 0/5] mxs-lradc: Split driver into MFD > > > > > > I'm inclined to agree with Dmitry: > > > > > > https://www.spinics.net/lists/linux-input/msg51061.html > > > > Not sure we can use devm_ioremap_resource(), if it is safe, I will > > send v2 version patch to use devm_ioremap_resource() instead. > > What makes you think it might not be safe? Last time, when I fix the same issue for other driver, and cause problem. So I am not sure whether we can convert to use devm_ioremap_resource. ==== Some pinctrls share memory regions, and devm_ioremap_resource does not allow to share resources, in opposition to devm_ioremap. This patch restores back usage of devm_ioremap function, but with proper error handling and logging. ==== https://www.spinics.net/lists/linux-samsung-soc/msg58366.html Regards, Yongjun Wei ��.n��������+%������w��{.n�����{��(��)�� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
