Re: [PATCH] iio:light: Add support for STMicro VL6180 sensor

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 17 March 2017 17:21:52 GMT+00:00, Peter Meerwald-Stadler <pmeerw@xxxxxxxxxx> wrote:
>
>> > A classic option would be to allow provision of a gpios to manually
>perform
>> > the reset.  Sounds like that's not an option on your board however.
>> >
>> > If not, is it possible to get the device to a known state by simply
>writing
>> > all it's registers?  If it's really impossible to continue in this
>state
>> > we need detailed explanation of why here in comments in the code.
>> 
>> Alright. I couldn't find a case where false reset might cause an
>issue. So,
>> it'd be better to skip the settings and allow the driver to work
>instead of
>> error out scenario.
>> 
>> Is this fine for you Jonathan?
>
>I think the fresh-out-of-reset thing is informative really
>we are writing the most relevant config registers anyway on probe
>
>I'd remove the check of the register or make it a log message only; the
>
>clearing of the register could be dependent on the check, however

Logging makes sense as might allow some future issue to be tracked down.
>
>regards, p.

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux