On Wed, Mar 1, 2017 at 11:53 AM, Julia Lawall <julia.lawall@xxxxxxx> wrote:
>
>
> On Wed, 1 Mar 2017, sayli karnik wrote:
>
>> The patch groups similar macros into enum data types.
>
> Like Alison said, I wonder why you changed the order.
>
Yes that was a mistake, I'll correct that along with other changes by
the reviewers, if any.
thanks,
sayli
> julia
>
>>
>> Signed-off-by: sayli karnik <karniksayli1995@xxxxxxxxx>
>> ---
>> drivers/staging/iio/adc/ad7280a.h | 20 ++++++++++++--------
>> 1 file changed, 12 insertions(+), 8 deletions(-)
>>
>> diff --git a/drivers/staging/iio/adc/ad7280a.h b/drivers/staging/iio/adc/ad7280a.h
>> index ccfb90d..08e97d4 100644
>> --- a/drivers/staging/iio/adc/ad7280a.h
>> +++ b/drivers/staging/iio/adc/ad7280a.h
>> @@ -13,15 +13,19 @@
>> * TODO: struct ad7280_platform_data needs to go into include/linux/iio
>> */
>>
>> -#define AD7280A_ACQ_TIME_400ns 0
>> -#define AD7280A_ACQ_TIME_800ns 1
>> -#define AD7280A_ACQ_TIME_1200ns 2
>> -#define AD7280A_ACQ_TIME_1600ns 3
>> +enum {
>> + AD7280A_CONV_AVG_DIS = 0,
>> + AD7280A_CONV_AVG_2,
>> + AD7280A_CONV_AVG_4,
>> + AD7280A_CONV_AVG_8,
>> +};
>>
>> -#define AD7280A_CONV_AVG_DIS 0
>> -#define AD7280A_CONV_AVG_2 1
>> -#define AD7280A_CONV_AVG_4 2
>> -#define AD7280A_CONV_AVG_8 3
>> +enum {
>> + AD7280A_ACQ_TIME_400ns = 0,
>> + AD7280A_ACQ_TIME_800ns,
>> + AD7280A_ACQ_TIME_1200ns,
>> + AD7280A_ACQ_TIME_1600ns,
>> +};
>>
>> #define AD7280A_ALERT_REMOVE_VIN5 BIT(2)
>> #define AD7280A_ALERT_REMOVE_VIN4_VIN5 BIT(3)
>> --
>> 2.7.4
>>
>> --
>> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
>> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@xxxxxxxxxxxxxxxx.
>> To post to this group, send email to outreachy-kernel@xxxxxxxxxxxxxxxx.
>> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170301052712.GA19851%40sayli-HP-15-Notebook-PC.
>> For more options, visit https://groups.google.com/d/optout.
>>
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@xxxxxxxxxxxxxxxx.
> To post to this group, send email to outreachy-kernel@xxxxxxxxxxxxxxxx.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/alpine.DEB.2.20.1703010723120.2079%40hadrien.
> For more options, visit https://groups.google.com/d/optout.
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
