On 30/12/16 20:49, Linus Walleij wrote:
> On Sat, Nov 19, 2016 at 4:18 PM, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
>> On Sat, Nov 19, 2016 at 2:07 PM, Jonathan Cameron <jic23@xxxxxxxxxx> wrote:
>>> On 16/11/16 21:15, Lorenzo Bianconi wrote:
>>>> Using realbits as i2c/spi read len, when that value is not byte aligned
>>>> (e.g 12 bits), lead to skip msb part of out data registers.
>>>> Fix this taking into account scan_type.shift in addition to
>>>> scan_type.realbits as read length:
>>>>
>>>> read_len = DIV_ROUND_UP(realbits + shift, 8)
>>>>
>>>> This fix has been tested on 8, 12, 16, 24 bit sensors
>>>>
>>>> Fixes: e7385de5291e ("iio:st_sensors: align on storagebits boundaries")
>>>> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@xxxxxx>
>>>
>>> Do highlight (typically below the --) what changes have occurred. I'm guessing this
>>> was mostly about testing on the 24 bit sensor and the additions in the core file.
>>>
>>> Applied to the fixes-togreg and marked for stable. I will probably sit on this one
>>> for a few days before sending upstream if anyone has any final comments on it.
>>
>> Makes all kind of sense.
>> Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
>
> After making my 12bit LIS3LV02 work again it is also:
> Tested-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
>
> And I think it should be tagged for stable.
Already was. In a bit of patch shuffling to avoid having multiple pull requests
I've cherry picked this one into the fixes-togreg-post-rc1 branch and added
Linus' tested-by. Will send a pull request in a few minutes.
Jonathan
>
> Yours,
> Linus Walleij
>
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
