Re: [PATCH v2] iio: common: st_sensors: fix channel data parsing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Nov 19, 2016 at 2:07 PM, Jonathan Cameron <jic23@xxxxxxxxxx> wrote:
> On 16/11/16 21:15, Lorenzo Bianconi wrote:
>> Using realbits as i2c/spi read len, when that value is not byte aligned
>> (e.g 12 bits), lead to skip msb part of out data registers.
>> Fix this taking into account scan_type.shift in addition to
>> scan_type.realbits as read length:
>>
>> read_len = DIV_ROUND_UP(realbits + shift, 8)
>>
>> This fix has been tested on 8, 12, 16, 24 bit sensors
>>
>> Fixes: e7385de5291e ("iio:st_sensors: align on storagebits boundaries")
>> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@xxxxxx>
>
> Do highlight (typically below the --) what changes have occurred.  I'm guessing this
> was mostly about testing on the 24 bit sensor and the additions in the core file.
>
> Applied to the fixes-togreg and marked for stable.  I will probably sit on this one
> for a few days before sending upstream if anyone has any final comments on it.

Makes all kind of sense.
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux