On Sun, 2016-11-27 at 11:12 +0000, Jonathan Cameron wrote: > On 24/11/16 14:28, Linus Walleij wrote: > > On Thu, Nov 24, 2016 at 6:33 AM, Shrirang Bagul > > <shrirang.bagul@xxxxxxxxxxxxx> wrote: > > > > > Compatible strings are not available on ACPI based systems. This patch > > > adds > > > support to use DSDT information read from platform BIOS instead for > > > probing > > > st pressure sensors. > > > > > > Signed-off-by: Shrirang Bagul <shrirang.bagul@xxxxxxxxxxxxx> > > > > (...) > > > +#ifdef CONFIG_ACPI > > > +static const struct acpi_device_id st_press_acpi_match[] = { > > > + {"SNO9210", LPS22HB}, > > > + { }, > > > +}; > > > > Same comment. One sensor only supported by ACPI really? > > As demonstrated by this one, they are often registered under effectively > random names! > Digging out those random names and associating them with a particular chip is > always > going to be a non trivial job. > > Hence I'm happy to take these as they stand. We can add more entries when we > come > across them. > > > > Take a wider look. Yes, I will. > > Shirang has done a good job identifying this one and sending it upstream. > Be nice Linus and don't try to get him to do all the hard work ;) > > As such applied to the togreg branch of iio.git. Will be pushed out as testing > for > the autobuilders to play with it. > > Note there will be some weeks before I push this out as togreg (given merge > window > is about to open) so plenty of time for others to take a look! > > Thanks, > > Jonathan Thank you Jonathan. I'll follow-up on Linus's suggestion and try and identify more of these sensors on some of the hardware we have in the lab. and try to add support for some more devices. Thanks, Shrirang > > > > Yours, > > Linus Walleij > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > > the body of a message to majordomo@xxxxxxxxxxxxxxx > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > > -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html