Re: [PATCH] hid: hid-sensor-hub: clear memory to avoid random data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2016-11-08 at 00:55 +0000, Song Hongyan wrote:
> Initialize user buffer with 0s. This will avoid random data in the
> buffer,
> when the user buffer size is bigger than the actual report size.
> 
You should change PATCH version when you update, otherwise maintainers
and reviewers will not know which one to review and apply.

So each time you update a change
- Use --subject-prefix to increment revision. E.g. --subject-
prefix="PATCH v2"

- The change log: If you have more than one patch in a patchset then
use --cover option and add to cover letter for each incremental
version. If you have a singe patch, the change log can go below "---"
below.

Also use ./scripts/get_maintainer.pl, script on the patch to get "to"
and "cc" list.

> Signed-off-by: Song Hongyan <hongyan.song@xxxxxxxxx>
> ---
Change log
v2:
xxxxxxxxxxxxxxx

Thanks,
Srinivas


>  drivers/hid/hid-sensor-hub.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-
> hub.c
> index 658a607..b74d954 100644
> --- a/drivers/hid/hid-sensor-hub.c
> +++ b/drivers/hid/hid-sensor-hub.c
> @@ -252,6 +252,7 @@ int sensor_hub_get_feature(struct
> hid_sensor_hub_device *hsdev, u32 report_id,
>  	int report_size;
>  	int ret = 0;
>  
> +	memset(buffer, 0, buffer_size);
>  	mutex_lock(&data->mutex);
>  	report = sensor_hub_report(report_id, hsdev->hdev,
> HID_FEATURE_REPORT);
>  	if (!report || (field_index >= report->maxfield) ||��.n��������+%������w��{.n�����{��(��)��jg��������ݢj����G�������j:+v���w�m������w�������h�����٥




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux