On 09/20/2016 05:35 PM, Peter Meerwald-Stadler wrote:
> On Tue, 20 Sep 2016, Lars-Peter Clausen wrote:
>
>> Add support for the AD7766, AD7766-1, AD7766-2, AD7767, AD7767-1, AD7767-2
>> Analog to Digital converters. It's a family of single channel 24-bit SAR
>> ADCs. They are all digital interface compatible and the main difference is
>> the internal decimation rate and analog performance. For communication with
>> the host processor a SPI interface is used.
>
> looks good, nitpicking below
Thanks for the review.
>> +static const struct iio_chan_spec ad7766_channels[] = {
>> + {
>> + .type = IIO_VOLTAGE,
>> + .indexed = 1,
>
> have only one channel and still indexed?
To be honest I prefer to make all channels indexed. There is no inherent
value added by using un-indexed channels. The only thing that changes is the
naming scheme of the channel attributes. This makes things more complex and
also adds ambiguity between shared attributes and channel attributes, which
makes it harder to parse by machines (and maybe also some humans).
- Lars
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
