Re: [PATCH] iio: st_sensors: fetch and enable regulators unconditionally

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 30, 2016 at 9:21 AM, Giuseppe BARBA <giuseppe.barba@xxxxxx> wrote:

>> > +   pdata->vdd_io = devm_regulator_get(indio_dev->dev.parent,
>> "vddio");
>> > +   if (IS_ERR(pdata->vdd)) {
> I think this check is not correct: you have to check the pdata->vdd_io and not
> the pdata->vdd (that is already checked before).
>
>> > +           dev_err(&indio_dev->dev, "unable to get Vdd_IO
>> supply\n");
>> > +           err = PTR_ERR(pdata->vdd);
> And here you should use the pdata->vdd_io.

Ah, of course, and I've even done that mistake before :(

I'll send a follow-up patch to fix the fix.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux