Re: [PATCH] fix:iio:common:st_sensors:st_sensors_trigger:mark symbols static where possible

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 27/08/16 09:44, Linus Walleij wrote:
> On Sat, Aug 27, 2016 at 8:26 AM, Baoyou Xie <baoyou.xie@xxxxxxxxxx> wrote:
> 
>> We get 2 warnings when biuld kernel with W=1:
>> drivers/iio/common/st_sensors/st_sensors_trigger.c:69:13: warning: no previous prototype
>> for 'st_sensors_irq_handler' [-Wmissing-prototypes]
>> drivers/iio/common/st_sensors/st_sensors_trigger.c:85:13: warning: no previous prototype
>> for 'st_sensors_irq_thread' [-Wmissing-prototypes]
>>
>> In fact, these functions are only used in the file in which they are
>> declared and don't need a declaration, but can be made static.
>> so this patch marks these functions with 'static'.
>>
>> Signed-off-by: Baoyou Xie <baoyou.xie@xxxxxxxxxx>
> 
> Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
Applied to the togreg branch of iio.git. Initially pushed out
as testing for the autobuilders to play with it.

Thanks,

Jonathan
> 
> Yours,
> Linus Walleij
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux