On 26/08/16 15:31, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
>
> When terminating for_each_child_of_node() iteration with
> break or return, of_node_put() should be used to prevent
> stale device node references from being left behind.
>
> This is detected by Coccinelle semantic patch.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
Thanks,
Applied to the togreg branch of iio.git. Initially pushed out
as testing for the autobuilders to play with it.
Jonathan
> ---
> drivers/iio/adc/ti-ads1015.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/iio/adc/ti-ads1015.c b/drivers/iio/adc/ti-ads1015.c
> index 066abaf..cde6f13 100644
> --- a/drivers/iio/adc/ti-ads1015.c
> +++ b/drivers/iio/adc/ti-ads1015.c
> @@ -522,6 +522,7 @@ static int ads1015_get_channels_config_of(struct i2c_client *client)
> if (pga > 6) {
> dev_err(&client->dev, "invalid gain on %s\n",
> node->full_name);
> + of_node_put(node);
> return -EINVAL;
> }
> }
> @@ -532,6 +533,7 @@ static int ads1015_get_channels_config_of(struct i2c_client *client)
> dev_err(&client->dev,
> "invalid data_rate on %s\n",
> node->full_name);
> + of_node_put(node);
> return -EINVAL;
> }
> }
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
