On 25/08/16 14:13, Linus Walleij wrote: > On Thu, Aug 25, 2016 at 2:37 PM, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote: > >>>> I suspect some of the stuff I've done here should be carried >>>> over to the MPU-6050 driver in drivers/iio/imu/inv_mpu6050/* >>> >>> Which bits in particular? >> >> - Fetch and handle regulators for vdd and vddio (currently >> totally missing). >> >> - Runtime PM, including getting rid of the horrible homebrewn >> reference count in inv_mpu6050_set_power_itg() >> >> - Oh mpu6050 doesn't even seem to power the device down >> on .remove() I think it's a bug actually > > Oh and when it comes to the trigger interrupts in > drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c > > - No active low handling (bit 7 reg 0x37) > > - No open drain handling (bit 6 reg 0x37) > > - No level interrupt support (bit 5 reg 0x37) > > - No check of status register to return IRQ_NONE > i.e. spurious IRQ handling is non-existent. > > - Timestamping should preferably happen in top > half. > > All of this should probably happen more like it happens > in this MPU-3050 driver. Instead it assumes that the > interrupt assigned will be an edge, low-to-high transition, > and nothing else is supported. Thanks. We may want to wait for Leonard to revisit his last series on that driver, before it changes too much. But would indeed be good to get this stuff sorted at somepoint! Jonathan > > Yours, > Linus Walleij > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
