Re: [PATCH v2 2/3] iio: chemical: atlas-ph-sensor: switch to REGCACHE_NONE regmap tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 19/08/16 21:36, Matt Ranostay wrote:
> Since there are overlapping volatile regions between parts, and only
> register that isn't volatile is the temperature compensation provided
> from userspace.
This does make me wonder if a shared regmap across the different parts
makes sense. (assuming I've understood the issue).

However, not many registers, not a quick device so who really cares ;)

Applied.

Thanks,

Jonathan
> 
> Signed-off-by: Matt Ranostay <mranostay@xxxxxxxxx>
> ---
>  drivers/iio/chemical/atlas-ph-sensor.c | 16 ----------------
>  1 file changed, 16 deletions(-)
> 
> diff --git a/drivers/iio/chemical/atlas-ph-sensor.c b/drivers/iio/chemical/atlas-ph-sensor.c
> index 696875413d10..c0a0ebbbd54a 100644
> --- a/drivers/iio/chemical/atlas-ph-sensor.c
> +++ b/drivers/iio/chemical/atlas-ph-sensor.c
> @@ -84,26 +84,10 @@ struct atlas_data {
>  	__be32 buffer[6]; /* 96-bit data + 32-bit pad + 64-bit timestamp */
>  };
>  
> -static const struct regmap_range atlas_volatile_ranges[] = {
> -	regmap_reg_range(ATLAS_REG_INT_CONTROL, ATLAS_REG_INT_CONTROL),
> -	regmap_reg_range(ATLAS_REG_PH_DATA, ATLAS_REG_PH_DATA + 4),
> -	regmap_reg_range(ATLAS_REG_EC_DATA, ATLAS_REG_PSS_DATA + 4),
> -};
> -
> -static const struct regmap_access_table atlas_volatile_table = {
> -	.yes_ranges	= atlas_volatile_ranges,
> -	.n_yes_ranges	= ARRAY_SIZE(atlas_volatile_ranges),
> -};
> -
>  static const struct regmap_config atlas_regmap_config = {
>  	.name = ATLAS_REGMAP_NAME,
> -
>  	.reg_bits = 8,
>  	.val_bits = 8,
> -
> -	.volatile_table = &atlas_volatile_table,
> -	.max_register = ATLAS_REG_PSS_DATA + 4,
> -	.cache_type = REGCACHE_RBTREE,
>  };
>  
>  static const struct iio_chan_spec atlas_ph_channels[] = {
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux