On Tue, Aug 16, 2016 at 3:53 PM, Peter Meerwald-Stadler <pmeerw@xxxxxxxxxx> wrote: >> +/** >> + * struct kxsd9_transport - transport adapter for SPI or I2C >> + * @trdev: transport device such as SPI or I2C >> + * @write1(): function to write a byte to the device >> + * @write2(): function to write two consecutive bytes to the device >> + * @readval(): function to read a 16bit value from the device >> + * @rx: cache aligned read buffer >> + * @tx: cache aligned write buffer > > tx doesn't seem to be cachline_aligned? Haha no, comment carried over when moving the code. I remove it later in the patch series. >> + void *trdev; >> + int (*write1) (struct kxsd9_transport *tr, u8 byte); >> + int (*write2) (struct kxsd9_transport *tr, u8 b1, u8 b2); >> + int (*readval) (struct kxsd9_transport *tr, u8 address); >> + u8 rx[KXSD9_STATE_RX_SIZE] ____cacheline_aligned; >> + u8 tx[KXSD9_STATE_TX_SIZE]; >> +}; >> + >> /** >> * struct kxsd9_state - device related storage > > should add transport and remove us, rx, tx Yeah. I remove it later in the patch series when switching the transport to regmap (IIRC) and this doesn't really cause any issues to have left until that point. But if you think it's worth it, I can respin it to make a cleaner patch. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
