Hi Linus, I can confirm that the crash exists. But is it possible to download / pull the patch from somewhere? It did not yet appear in linux-next. Is it applied to some other git repo? Unfortunately linux-iio isn't available in patchwork.kernel.org and this patch didn't cc: to lkml. And the trick I just recently learned how to download it from gmane does not work any more. Finally markinfo does not appear to have a binary download either which preserves subject&headers. http://marc.info/?l=linux-iio&m=146965159217655&w=2 Well, I can still pull from this e-mail or copy&paste into a text file, but sometimes formatting can go wrong. BR and thanks, Nikolaus > Am 27.07.2016 um 22:32 schrieb Linus Walleij <linus.walleij@xxxxxxxxxx>: > > In commit 3d838118c6aa ("iio: pressure: bmp280: add power management") > > For some reason the code in the runtime suspend/resume hooks > got wrong (I suspect in the ambition to cut down boilerplate) > and it seems it was tested without CONFIG_PM and crashes like > so for me: > > Unable to handle kernel NULL pointer dereference at virtual address 0000000c > pgd = c0204000 > [0000000c] *pgd=00000000 > Internal error: Oops: 5 [#1] PREEMPT SMP ARM > Modules linked in: > CPU: 1 PID: 89 Comm: kworker/1:2 Not tainted > 4.7.0-03348-g90dc3680458a-dirty #99 > Hardware name: Generic DT based system > Workqueue: pm pm_runtime_work > task: df3c6300 ti: dec8a000 task.ti: dec8a000 > PC is at regulator_disable+0x0/0x6c > LR is at bmp280_runtime_suspend+0x3c/0xa4 > > Dereferencing the BMP280 state container properly fixes the problem, > sorry for screwing up. > > Fixes: 3d838118c6aa ("iio: pressure: bmp280: add power management") > Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > --- > drivers/iio/pressure/bmp280-core.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/pressure/bmp280-core.c b/drivers/iio/pressure/bmp280-core.c > index 6943688e66df..724fefd4af00 100644 > --- a/drivers/iio/pressure/bmp280-core.c > +++ b/drivers/iio/pressure/bmp280-core.c > @@ -1079,7 +1079,8 @@ EXPORT_SYMBOL(bmp280_common_remove); > #ifdef CONFIG_PM > static int bmp280_runtime_suspend(struct device *dev) > { > - struct bmp280_data *data = dev_get_drvdata(dev); > + struct iio_dev *indio_dev = dev_get_drvdata(dev); > + struct bmp280_data *data = iio_priv(indio_dev); > int ret; > > ret = regulator_disable(data->vdda); > @@ -1090,7 +1091,8 @@ static int bmp280_runtime_suspend(struct device *dev) > > static int bmp280_runtime_resume(struct device *dev) > { > - struct bmp280_data *data = dev_get_drvdata(dev); > + struct iio_dev *indio_dev = dev_get_drvdata(dev); > + struct bmp280_data *data = iio_priv(indio_dev); > int ret; > > ret = regulator_enable(data->vddd); > -- > 2.7.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
