Re: [PATCH] HC-SR04 ultrasonic ranger IIO driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

Am 07.06.16 um 17:19 schrieb Lars-Peter Clausen:

Any new ABI needs to be documented in Documentation/ABI/...

I will move it there thanks for pointing that out.

But to take one thing ahead passing the GPIO number (or a label) from
userspace is not really a good ABI in my opinion. The GPIO numbers should
come from the hardware description (DTS, ACPI, board file, ...)

I wanted to offer the possibility to configure the device at run time. Since it is not part of the board but a periphial device it could also be attached while the system is running. I would like to keep this interface but will add support for also configue it via device tree, as you suggested.
+	do_gettimeofday(&now);

gettimeofday is not a good function if you want to measure elapsed time
since the returned value jumps around when the system time is changed. Try
to use one of the monotonic time sources, those are guaranteed not to jump
around.
Thanks I didn't think about that.

Kind regards,

- Johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux