On 02/06/16 11:53, Michael Hennerich wrote:
> On 06/02/2016 12:06 PM, Colin King wrote:
>> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>>
>> The check on reg is off-by-one, it should be >= rather than >. Fix
>> this to stop an out-of-bounds write to st->channel_modes[reg].
>>
>> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> Acked-by: Michael Hennerich <michael.hennerich@xxxxxxxxxx>
Already have a fix queued from the 29th of April - will push out
in the next few days. It just managed to miss going out in the
last cycle by a few days.
Thanks,
Jonathan
>
>> ---
>> drivers/iio/dac/ad5592r-base.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/iio/dac/ad5592r-base.c b/drivers/iio/dac/ad5592r-base.c
>> index 948f600..69bde59 100644
>> --- a/drivers/iio/dac/ad5592r-base.c
>> +++ b/drivers/iio/dac/ad5592r-base.c
>> @@ -525,7 +525,7 @@ static int ad5592r_alloc_channels(struct ad5592r_state *st)
>>
>> device_for_each_child_node(st->dev, child) {
>> ret = fwnode_property_read_u32(child, "reg", ®);
>> - if (ret || reg > ARRAY_SIZE(st->channel_modes))
>> + if (ret || reg >= ARRAY_SIZE(st->channel_modes))
>> continue;
>>
>> ret = fwnode_property_read_u32(child, "adi,mode", &tmp);
>>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
