Re: [PATCH 2/2 v6] iio: st_sensors: read surplus samples in trigger

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 10, 2016 at 6:40 PM, Crestez Dan Leonard
<leonard.crestez@xxxxxxxxx> wrote:
> [Me]
>> ChangeLog v5->v6:
>> - Add a loop counter to the threaded value poll function: let's
>>   just loop here for at maximum 10 loops before we exit and
>>   let the thread re-trigger if more interrupts arrived.
>
> This only serves to hide the problem.

Not really. The system can preempt after exiting the thread but
before processing the next set of samples.

> Version 5 seems preferable. Or
> even just adding msleep(10) in that infinite loop.

That provides a preemption point I guess but usleep_range()
is usually preferrable for such cases. 10ms is way to long
time to wait, because the max sample frequency will be
1/10ms = 100Hz and some ST sensors I have support
1kHz updates even. The usleep range would need to be
very short.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux