Thanks for your mails. Just FYI, we are testing this tmp006 sensor on our system. and our application framework is using these device names, so I submitted this patch. Yong 2016-04-26 18:57 GMT+08:00 Lars-Peter Clausen <lars@xxxxxxxxxx>: > On 04/25/2016 11:11 PM, Jonathan Cameron wrote: >> On 25/04/16 21:59, Crestez Dan Leonard wrote: >>> On 04/25/2016 10:33 PM, Jonathan Cameron wrote: >>>> On 22/04/16 04:43, Yong Li wrote: >>>>> When load the driver using the below command: >>>>> echo tmp006 0x40 > /sys/bus/i2c/devices/i2c-0/new_device >>>>> >>>>> In sysfs, the i2c name is tmp006, however the iio name is 0-0040, >>>>> they are inconsistent. With this patch, >>>>> the iio name will be the same as the i2c device name >>>>> >>>>> Signed-off-by: Yong Li <sdliyong@xxxxxxxxx> >>>> Peter, this looks right to me, but could you take a quick look as I guess >>>> there might be a reason you did this in an unusual way originally? >>>> >>> Is there a "correct" or "usual" way to set indio_dev->name? Some quick grepping shows no clear standard: >>> >>> $ git grep -h 'indio_dev->name =' drivers/iio/ | wc -l >>> 148 >>> $ git grep -h 'indio_dev->name =' drivers/iio/ | grep id | wc -l >>> 52 >>> $ git grep -h 'indio_dev->name =' drivers/iio/ | grep dev_name | wc -l >>> 20 >>> $ git grep -h 'indio_dev->name =' drivers/iio/ | grep -i drv | wc -l >>> 19 >>> $ git grep -h 'indio_dev->name =' drivers/iio/ | grep -i driver | wc -l >>> 15 >>> >>> It seems that many devices use dev_name(&i2c_client->dev) or >>> otherwise some sort of "ABC123_DRIVER_NAME" constant. >>> >>> It's also not clear what this "name" field is for. Is it more than >>> just a cosmetic sysfs attribute? It seems to me that names don't have >>> to be unique so it would be wrong to use them for identification. >>> >> It's a convenience field really as there is no clear standard for where else >> to find out what a part actually is (i.e. if it is an i2c part you can look >> in the name attribute i2c supplies - but otherwise you are on your own). > > I'd like to argue that it is supposed to be the device type allowing the > application to identify which kind of device they are talking to. In which > case the dev_name() initialization is wrong. Unfortunately there seem quite > a few drivers which use it, especially the the SoC ADC drivers. But we can't > really change this for existing drivers since there might be applications > relying on the name. > > We should pay more attention to this for new driver submissions and make > sure we don't get any more of this. > > As a side note if you want to know the dev_name() of the parent device you > can do a readlink() on the iio device in /sys/bus/iio/devices/. The second > last entry in the path name is the name of the parent device. -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
