On Sun, Apr 17, 2016 at 01:07:52PM -0500, Andrew F. Davis wrote: > On 04/16/2016 02:22 PM, Jonathan Cameron wrote: > > On 10/04/16 20:07, Alison Schofield wrote: > >> Driver includes struct regmap and struct device in its global data. > >> Remove the struct device and use regmap API to retrieve device info. > >> > > Why? This adds nothing but more code to get dev through some > container_of trickery when we could just keep a dev pointer in the data > structure. > > Andrew Thanks for the review and response. The why would be for simplification and uniformity across IIO. I think I see your point in general, but not sure I get your specific concerns with these afe4403/04 drivers. The drivers only use the device struct in probe and then again at device remove time. At probe, the change no longer stores it in the global data. At remove the regmap_get_device() func is a simple dereference to retrieve the device struct. That's the simplification: we don't carry that ptr in global data waiting for the opportunity to use it at device remove. We just find it when we need it at device remove. (Perhaps these devices are getting removed frequently?) Regards, alisons -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
