On 18/03/16 03:48, Matt Ranostay wrote:
> Correct issue that the last entry in FIFO was being read twice due
> to an incorrect decrement of entry count variable before condition
> check.
>
> Signed-off-by: Matt Ranostay <mranostay@xxxxxxxxx>
Applied to the fixes branch of iio.git.
Thanks,
Jonathan
> ---
> drivers/iio/light/apds9960.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/light/apds9960.c b/drivers/iio/light/apds9960.c
> index f6a07dc..a6af56a 100644
> --- a/drivers/iio/light/apds9960.c
> +++ b/drivers/iio/light/apds9960.c
> @@ -769,7 +769,7 @@ static void apds9960_read_gesture_fifo(struct apds9960_data *data)
> mutex_lock(&data->lock);
> data->gesture_mode_running = 1;
>
> - while (cnt-- || (cnt = apds9660_fifo_is_empty(data) > 0)) {
> + while (cnt || (cnt = apds9660_fifo_is_empty(data) > 0)) {
> ret = regmap_bulk_read(data->regmap, APDS9960_REG_GFIFO_BASE,
> &data->buffer, 4);
>
> @@ -777,6 +777,7 @@ static void apds9960_read_gesture_fifo(struct apds9960_data *data)
> goto err_read;
>
> iio_push_to_buffers(data->indio_dev, data->buffer);
> + cnt--;
> }
>
> err_read:
>
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
