On Wed, Mar 9, 2016 at 1:20 PM, Gregor Boirie <gregor.boirie@xxxxxxxxxx> wrote: > > > On 03/09/2016 11:06 AM, Martin Kepplinger wrote: >> >> Am 2016-03-09 um 11:02 schrieb Gregor Boirie: >>> >>> Hi Daniel, >>> >>> On 03/08/2016 10:16 PM, Daniel Baluta wrote: >>>> >>>> On Tue, Mar 8, 2016 at 8:00 PM, Gregor Boirie >>>> <gregor.boirie@xxxxxxxxxx> wrote: >>>>> >>>>> When not compiled-in, regulator layer will return a NULL pointer when >>>>> trying to get a reference to any regulator using >>>>> devm_regulator_get(). As >>>>> IS_ERR() does not consider this an error, the ms5611 probing >>>>> operation will >>>>> try to enable a NULL regulator, which will invariably cause a kernel >>>>> crash. >>>>> This patch fixes this situation by using devm_regulator_get_optional() >>>>> instead of devm_regulator_get(). >>>>> >>>>> Signed-off-by: Gregor Boirie <gregor.boirie@xxxxxxxxxx> >>>> >>>> $Subject should be here. And the commit subject should be something >>>> more appropriate like: >>>> >>>> iio: pressure: ms5611: Fix crash when ... >>> >>> I'm a bit lost here since when Jonathan asked for "a fixes tag" inclusion >>> (http://permalink.gmane.org/gmane.linux.kernel.iio/22425), I supposed he >>> meant a tag such as one described in the Documentation/SubmittingPatches >>> file. >>> My initial attempt was sent with the subject: >>> "iio:pressure:ms5611: fix oops when probing regulator". The initial subject was OK. >>> >>> Would you please be kind enough to give me some sort of rules as to when >>> and how >>> to write subject lines related to fixes patch ? >>> >> I guess you can just put in a "Fixes:" line, along with your >> "Signed-off-by:" lines. > > Oh... <light bulb enlightenment/> ! I definitely need some decent manners > lessons :) > Thanks. What Martin said :). For example, you can look at this patch: https://lkml.org/lkml/2016/2/16/505 Daniel. -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
