Sure. I will do that. Thanks.:-) Ge ________________________________________ From: daniel.baluta@xxxxxxxxx <daniel.baluta@xxxxxxxxx> on behalf of Daniel Baluta <daniel.baluta@xxxxxxxxx> Sent: Thursday, February 25, 2016 12:45 AM To: Ge Gao Cc: Jonathan Cameron; Matt Ranostay; linux-iio@xxxxxxxxxxxxxxx; daniel.baluta@xxxxxxxxx; adriana.reus@xxxxxxxxx Subject: Re: [PATCH 0/5] mpu6050: code clean and calibration support On Thu, Feb 25, 2016 at 12:04 AM, Ge Gao <GGao@xxxxxxxxxxxxxx> wrote: > Dear all, > It looks good to me. > Thanks. > Hi Ge :), Thanks for having a look at this. For next patches please also add the kernel formal Acked-by tag, like this: Acked-by: Ge Gao <GGao@xxxxxxxxxxxxxx> so that Jonathan can mark your collaboration into the commit message. > Best Regards, > > Ge Gao > > > -----Original Message----- > From: Jonathan Cameron [mailto:jic23@xxxxxxxxxx] > Sent: Wednesday, February 24, 2016 1:08 PM > To: Matt Ranostay > Cc: linux-iio@xxxxxxxxxxxxxxx; daniel.baluta@xxxxxxxxx; adriana.reus@xxxxxxxxx; Ge Gao > Subject: Re: [PATCH 0/5] mpu6050: code clean and calibration support > > On 22/02/16 21:39, Matt Ranostay wrote: >> The patchset series cleans up several documentation, return code >> issues, incorrect timing delays, and adds accl/gyro offset support. >> >> Matt Ranostay (5): >> iio: imu: mpu6050: use inv_mpu6050_sensor_show return code >> iio: imu: mpu6050: fix INV_MPU6050_REG_UP_TIME delay >> iio: imu: mpu6050: add missing docstring for int_pin_cfg >> iio: imu: mpu6050: add calibration offset support >> iio: imu: mpu6050: add mpu6500 register settings >> >> drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 88 >> +++++++++++++++++++++++++++--- >> drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c | 6 +- >> drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h | 20 ++++++- >> drivers/iio/imu/inv_mpu6050/inv_mpu_spi.c | 3 +- >> 4 files changed, 105 insertions(+), 12 deletions(-) >> > Whole series looks good to me (the typo fix can follow if you like :) > > Ideally I'd like Ge to take a look as well (+ anyone else who fancies doing so!) so will leave it on list for a few days more. > > Jonathan -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
