Re: [PATCH v3] iio: adc: Add TI ADS1015 ADC driver support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Would it be more consistent to handle the mutex outside of the switch above similar
> to how it is handled in ads1015_write_raw?
>
> Also the ads1015_set_power_state(data, false) is called either way so why not just
> use one call?
>

I don't have a strong preference for that. I think across IIO drivers
we can find both coding practices.

Indeed consistency with ads1015_write_raw is a good argument. Will fix it.

I will leave the code here for one more day and then send an updated version.

thanks,
Daniel.
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux