Dear all, The patch looks fine to me. Thanks for the change. Best Regards, Ge Gao -----Original Message----- From: Adriana Reus [mailto:adriana.reus@xxxxxxxxx] Sent: Monday, February 01, 2016 1:01 AM To: Jonathan Cameron Cc: linux-iio@xxxxxxxxxxxxxxx; srinivas.pandruvada@xxxxxxxxxxxxxxx; Ge Gao Subject: Re: [RFC PATCH 0/5] iio: imu: inv_mpu6050: Split driver into core and I2C/SPI functionality Hi, Thanks for your comments on this series, I'll resend a new version soon. It was an RFC because I've done some slight rebasing and shuffling around between my last tested version of this series and what was sent out and I wanted to make sure I can give it a final test run before it gets merged. As testing goes, I am using an mpu6050 to test the i2c part and an mpu6000 to test the spi part. Thanks, Adriana On 30.01.2016 19:11, Jonathan Cameron wrote: > On 30/01/16 09:43, Adriana Reus wrote: >> This series splits this driver into general and I2C/SPI specific funtionality. > functionality. >> The first patch is a fix for a bug in the interrupt pin configuration. >> The second patch is a minor clean up in preparation for the split. >> The third patch changes all the I2C specific calls into regmap calls. >> The third patch separated the remaining I2C specific part into a different component. >> Finally the fourth patch adds SPI support for the MPU6000 chip. > If sending an RFC, always state why you think it is not ready to merge > right now. > > Jonathan >> >> Adriana Reus (5): >> iio: imu: inv-mpu6050: Fix interrupt pin configuration >> iio: inv_mpu6050: Remove unused parameter >> iio: imu: inv_mpu6050: Use regmap instead of i2c specific functions >> iio: imu: inv_mpu6050: Separate driver into core and i2c >> functionality. >> iio: imu: inv_mpu6050: Add SPI support for MPU6000 >> >> drivers/iio/imu/inv_mpu6050/Kconfig | 15 +- >> drivers/iio/imu/inv_mpu6050/Makefile | 8 +- >> drivers/iio/imu/inv_mpu6050/inv_mpu_acpi.c | 14 +- >> drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 259 ++++++-------------------- >> drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c | 209 +++++++++++++++++++++ >> drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h | 15 +- >> drivers/iio/imu/inv_mpu6050/inv_mpu_ring.c | 34 ++-- >> drivers/iio/imu/inv_mpu6050/inv_mpu_spi.c | 80 ++++++++ >> drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c | 10 +- >> 9 files changed, 402 insertions(+), 242 deletions(-) >> create mode 100644 drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c >> create mode 100644 drivers/iio/imu/inv_mpu6050/inv_mpu_spi.c >> > -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
