Re: [PATCH 2/3] iio: dht11: Simplify decoding algorithm

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jonathan Cameron writes:
> On 30/12/15 14:26, Harald Geyer wrote:
> > The new algorithm uses a 'one size fits em all' threshold, which should
> > be easier to understand and debug. I believe there are no regressions
> > compared to the old adaptive threshold algorithm. I don't remember why
> > I chose the old algorithm when I initially wrote the driver.
> > 
> > Signed-off-by: Harald Geyer <harald@xxxxxxxxx>
> Hmm. Couple of trivial bits inline.
> 
> I'd like some tested-by's on this one if possible...
> 
> Such a 'fun' device ;)

On the up-side its working on poor and long wiring almost as well as
on good and short wiring ... ;)
 
> > -		timing[i] = t / timeres;
> > +		bits[i] = t > DHT11_THRESHOLD ? 1 : 0;
> t > DHT11_THRESHOLD is already going to give 0 or 1...

Thanks. I'll send a v2 after everybody has had enough time to test and
comment on the whole series.

Harald
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux