On 12/03/2015 07:18 PM, Jonathan Cameron wrote: > On 03/12/15 16:07, Daniel Baluta wrote: >> I see, strange. It shouldn't complain about it, because it is immediately exported. >> >> I will have a closer look. > Indeed, it's clearly BS (serves me right for fly by sparse fixing during > applying patches:). Looking at the moment like a bug in Sparse which is > unusual... > > cc'd the list as maybe someone else will be able to suggest what is going on here. sparse complains if there is no forward declaration in a header file. This could either mean there is non or the header file is not included in the C file where it is defined. >> >> >> struct configfs_subsystem iio_configfs_subsys = { >> » .su_group = { >> » » .cg_item = { >> » » » .ci_namebuf = "iio", >> » » » .ci_type = &iio_root_group_type, >> » » }, >> » }, >> » .su_mutex = __MUTEX_INITIALIZER(iio_configfs_subsys.su_mutex), >> }; >> EXPORT_SYMBOL(iio_configfs_subsys); >> >> >> >> >> On 12/03/2015 05:53 PM, Jonathan Cameron wrote: >>> Classic symbol not exported should it be static from sparse. >>> >>> On 3 December 2015 08:57:25 GMT+00:00, Daniel Baluta >>> <daniel.baluta@xxxxxxxxx> wrote: >>> >>> Ooops, yes! >>> >>> Sorry for the late answer, Jonathan :(. >>> >>> What was the warning you got and fixed with adding static? >>> >>> thanks, >>> Daniel >>> >>> On 12/03/2015 08:41 AM, Jonathan Cameron wrote: >>> >>> I'll back that static addition out then! >>> >>> On 2 December 2015 23:23:27 GMT+00:00, kbuild test robot >>> <fengguang.wu@xxxxxxxxx> wrote: >>> >>> tree:https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git >>> togreg >>> head: 5a9776becbe3a15f0616883244142b3e6addf93b >>> commit: 13bbe76b0b58c958ea6b9fcb982ca5f969f89d48 [11/13] iio: >>> core: Introduce IIO software triggers >>> config: i386-allyesconfig (attached as .config) >>> reproduce: >>> git checkout 13bbe76b0b58c958ea6b9fcb982ca5f969f89d48 >>> # save the attached .config to linux build tree >>> make ARCH=i386 >>> >>> All errors (new ones prefixed by >>): >>> >>> drivers/built-in.o: In function `iio_sw_trigger_init': >>> >>> industrialio-sw-trigger.c:(.init.text+0x801d0): undefined >>> reference to `iio_configfs_subsys' >>> >>> >>> --- >>> 0-DAY kernel test infrastructure Open Source Technology Center >>> https://lists.01.org/pipermail/kbuild-all Intel Corporation >>> >>> >>> -- >>> Sent from my Android device with K-9 Mail. Please excuse my brevity. >>> >>> >>> -- >>> Sent from my Android device with K-9 Mail. Please excuse my brevity. > -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html