Re: [PATCH] staging:iio:ad7780: Switch to the gpio descriptor interface

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/18/2015 11:23 AM, Dragos Bogdan wrote:
> Use the gpiod interface for the powerdown_gpio instead of the deprecated
> old non-descriptor interface.
> 
> The powerdown pin can be tied high, so the gpio is optional.
> Remove the gpio_pdrst platform_data member since the new interface is
> used.
> 
> Signed-off-by: Dragos Bogdan <dragos.bogdan@xxxxxxxxxx>

Thanks, looks mostly good. One comment inline.

> ---
>  drivers/staging/iio/adc/ad7780.c | 26 +++++++++++---------------
>  drivers/staging/iio/adc/ad7780.h |  1 -
>  2 files changed, 11 insertions(+), 16 deletions(-)
> 
> diff --git a/drivers/staging/iio/adc/ad7780.c b/drivers/staging/iio/adc/ad7780.c
> index 618b41f..a5c5a95 100644
> --- a/drivers/staging/iio/adc/ad7780.c
> +++ b/drivers/staging/iio/adc/ad7780.c
> @@ -16,6 +16,7 @@
>  #include <linux/err.h>
>  #include <linux/sched.h>
>  #include <linux/gpio.h>

I think this include can be removed now.

[...]
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux