On Mon, Nov 16, 2015 at 7:02 AM, Denis Ciocca <denis.ciocca@xxxxxx> wrote: >> -static int st_sensors_write_data_with_mask(struct iio_dev *indio_dev, >> - u8 reg_addr, u8 mask, u8 >> data) +int st_sensors_write_data_with_mask(struct iio_dev *indio_dev, >> + u8 reg_addr, u8 mask, u8 data) >> { >> int err; >> u8 new_data; > > This function should include EXPORT_SYMBOL() if drivers are used as modules. Not a problem: st_sensors-y := st_sensors_core.o st_sensors-$(CONFIG_IIO_BUFFER) += st_sensors_buffer.o st_sensors-$(CONFIG_IIO_TRIGGER) += st_sensors_trigger.o And CONFIG_IIO_TRIGGER is a bool. So if it is used, it is always baked into st_sensors_core.o. (And that is why I chose to create a local header for it.) Fixing the rest of the problems, thanks Denis! Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html