On Wed, Nov 11, 2015 at 4:59 PM, Giuseppe BARBA <giuseppe.barba@xxxxxx> wrote: > Hi Daniel, > > thank you for the review. > > On 11/11/2015 15:45, Daniel Baluta wrote: >> On Wed, Nov 11, 2015 at 3:52 PM, Giuseppe Barba <giuseppe.barba@xxxxxx> wrote: >>> This commit add support for STMicroelectronics lis2dh12 accelerometer. >> >> Link to datasheet? > > The datasheet link is: > > http://www.st.com/st-web-ui/static/active/en/resource/technical/document/datasheet/DM00091513.pdf Care to send v3 with the commit message updated with the link to datasheet? > >> >> The subject should start with [PATCH v2] ... >> >>> >>> Signed-off-by: Giuseppe Barba <giuseppe.barba@xxxxxx> >>> --- >> >> Here you should add a short changelog with what you changed since v1. > > Yes I can do that if needed but it is just a typo on > LIS2DH12_ACCEL_DEV_NAME macro where I've used a minus instead of > underscore char. Usually, it's easier for reviewers to check your patch having the change log even if there is a minor change like yours. thanks, Daniel. -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
