On 26 October 2015 17:20:46 GMT+00:00, Alison Schofield <amsfield22@xxxxxxxxx> wrote: >On Mon, Oct 26, 2015 at 10:11:05AM +0200, Daniel Baluta wrote: >> >> >> On 10/23/2015 07:54 PM, Alison Schofield wrote: >> >Cleanups related to the usage of dummy_scan_elements in the >> >iio dummy driver: >> >- change enum names to upper case INDEX_* >> >- use the enum for IIO_CHAN_SOFT_TIMESTAMP (rm hard coded value) >> >- comment edited to match changes & follow preferred kernel style >> > >> >Signed-off-by: Alison Schofield <amsfield22@xxxxxxxxx> >> >--- >> > drivers/staging/iio/iio_simple_dummy.c | 22 >++++++++++++---------- >> > drivers/staging/iio/iio_simple_dummy.h | 20 >+++++++++++--------- >> > drivers/staging/iio/iio_simple_dummy_buffer.c | 9 +++++---- >> > 3 files changed, 28 insertions(+), 23 deletions(-) >> > >> >diff --git a/drivers/staging/iio/iio_simple_dummy.c >b/drivers/staging/iio/iio_simple_dummy.c >> >index 381f90f..5e19068 100644 >> >--- a/drivers/staging/iio/iio_simple_dummy.c >> >+++ b/drivers/staging/iio/iio_simple_dummy.c >> >@@ -1,4 +1,4 @@ >> >-/** >> >+/* >> This change should be in the 3rd patch. >> >Thanks for the eagle eyes! I see this (and the other comment I edit'd >also.) It leads to another question. > >In these dummy files, there are 27 comment blocks that start with >/** instead of /* . I touched 2 of them as a passerby, but now >that I'm looking.... should I change them all or is /** that an >acceptable >variation. > >alison > > >< snip > Good thing you raised this as one instance in the patch was an incorrect change away from ** Basically it should have two stars if kernel-doc (formal kernel documentation) and one star if a straightforward inline comment. See Documentation/kernel-doc-nano-howto.txt -- Sent from my Android device with K-9 Mail. Please excuse my brevity. -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
