Insu Yun schrieb am 19.10.2015 um 18:08: > Since devm_regulator_get returns address or error, not NULL, > it needs to be checked with IS_ERR, not IS_ERR_OR_NULL. > Actually, it does return NULL, if regulator support is disabled (see [1]). [1]http://lxr.free-electrons.com/source/include/linux/regulator/consumer.h#L286 > Signed-off-by: Insu Yun <wuninsu@xxxxxxxxx> > --- > drivers/iio/adc/ad7266.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/ad7266.c b/drivers/iio/adc/ad7266.c > index 70f78c3..26cd54b 100644 > --- a/drivers/iio/adc/ad7266.c > +++ b/drivers/iio/adc/ad7266.c > @@ -397,7 +397,7 @@ static int ad7266_probe(struct spi_device *spi) > st = iio_priv(indio_dev); > > st->reg = devm_regulator_get(&spi->dev, "vref"); > - if (!IS_ERR_OR_NULL(st->reg)) { > + if (!IS_ERR(st->reg)) { > ret = regulator_enable(st->reg); > if (ret) > return ret; > -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
