On 10/14/2015 04:04 PM, Daniel Baluta wrote: > On Tue, Oct 13, 2015 at 7:05 PM, Lars-Peter Clausen <lars@xxxxxxxxxx> wrote: >> For buffers which have a fixed wake-up watermark the watermark attribute >> should be read-only. Add a new FIXED_WATERMARK flag to the >> struct iio_buffer_access_funcs, which can be set by a buffer >> implementation. >> >> Signed-off-by: Lars-Peter Clausen <lars@xxxxxxxxxx> >> --- >> drivers/iio/industrialio-buffer.c | 5 +++++ >> include/linux/iio/buffer.h | 8 ++++++++ >> 2 files changed, 13 insertions(+) >> >> diff --git a/drivers/iio/industrialio-buffer.c b/drivers/iio/industrialio-buffer.c >> index 5f2c8c8..98a6447 100644 >> --- a/drivers/iio/industrialio-buffer.c >> +++ b/drivers/iio/industrialio-buffer.c >> @@ -998,6 +998,8 @@ static DEVICE_ATTR(enable, S_IRUGO | S_IWUSR, >> iio_buffer_show_enable, iio_buffer_store_enable); >> static DEVICE_ATTR(watermark, S_IRUGO | S_IWUSR, >> iio_buffer_show_watermark, iio_buffer_store_watermark); >> +static struct device_attribute dev_attr_watermark_ro = __ATTR(watermark, >> + S_IRUGO, iio_buffer_show_watermark, NULL); > > I think we can use DEVICE_ATTR_RO here. The problem is that this will generate a variable with the name dev_attr_watermark, which we already have for the rw version. So there would be a name conflict. Thanks for the review, - Lars -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
