On 12 October 2015 18:59:57 BST, Daniel Baluta <daniel.baluta@xxxxxxxxx> wrote: ><snip> > >>> +static unsigned instances = 1; >>> +module_param(instances, uint, 0); > >One concern about this. We will still create a default number of >'instances' >when using configuration via configfs? > >I'm not sure we can remove this parameter once the module is moved >out of staging, since we break the ABI (?) I'm not that bothered about ABI breakage on this one. Not going to break anything real after all! > >The rest looks good to me. I'm pretty sure that moving this out of >staging >will make the module more visible and people will jump with >enhancements. > > >thanks, >Daniel >-- >To unsubscribe from this list: send the line "unsubscribe linux-iio" in >the body of a message to majordomo@xxxxxxxxxxxxxxx >More majordomo info at http://vger.kernel.org/majordomo-info.html -- Sent from my Android device with K-9 Mail. Please excuse my brevity. -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
