On 31/08/15 20:46, Daniel Baluta wrote:
> On Sat, Aug 29, 2015 at 12:59 AM, Hartmut Knaack <knaack.h@xxxxxx> wrote:
>> A return variable is not required in _write_raw(), and dropping it reduces
>> complexity, as well.
>>
>> Signed-off-by: Hartmut Knaack <knaack.h@xxxxxx>
>
> Acked-by: Daniel Baluta <daniel.baluta@xxxxxxxxx>
>
> Initially forgot to CC linux-iio.
Applied.
>
>> ---
>> drivers/iio/dac/m62332.c | 8 ++------
>> 1 file changed, 2 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/iio/dac/m62332.c b/drivers/iio/dac/m62332.c
>> index fe750982b502..1b65fc007bce 100644
>> --- a/drivers/iio/dac/m62332.c
>> +++ b/drivers/iio/dac/m62332.c
>> @@ -112,21 +112,17 @@ static int m62332_read_raw(struct iio_dev *indio_dev,
>> static int m62332_write_raw(struct iio_dev *indio_dev,
>> struct iio_chan_spec const *chan, int val, int val2, long mask)
>> {
>> - int ret;
>> -
>> switch (mask) {
>> case IIO_CHAN_INFO_RAW:
>> if (val < 0 || val > 255)
>> return -EINVAL;
>>
>> - ret = m62332_set_value(indio_dev, val, chan->channel);
>> - break;
>> + return m62332_set_value(indio_dev, val, chan->channel);
>> default:
>> - ret = -EINVAL;
>> break;
>> }
>>
>> - return ret;
>> + return -EINVAL;
>> }
>>
>> #ifdef CONFIG_PM_SLEEP
>> --
>> 2.4.6
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
>> the body of a message to majordomo@xxxxxxxxxxxxxxx
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
