Re: [PATCH] iio: adc: vf610: fix simple_return.cocci warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 22/09/15 03:16, kbuild test robot wrote:
> drivers/iio/adc/vf610_adc.c:766:1-4: WARNING: end returns can be simpified and declaration on line 755 can be dropped
> 
>  Simplify a trivial if-return sequence.  Possibly combine with a
>  preceding function call.
> 
> Generated by: scripts/coccinelle/misc/simple_return.cocci
> 
> CC: Sanchayan Maity <maitysanchayan@xxxxxxxxx>
> Signed-off-by: Fengguang Wu <fengguang.wu@xxxxxxxxx>
Applied to the togreg branch of iio.git.

Thanks,

Jonathan
> ---
> 
>  vf610_adc.c |    8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> --- a/drivers/iio/adc/vf610_adc.c
> +++ b/drivers/iio/adc/vf610_adc.c
> @@ -752,7 +752,7 @@ static int vf610_adc_buffer_predisable(s
>  {
>  	struct vf610_adc *info = iio_priv(indio_dev);
>  	unsigned int hc_cfg = 0;
> -	int val, ret;
> +	int val;
>  
>  	val = readl(info->regs + VF610_REG_ADC_GC);
>  	val &= ~VF610_ADC_ADCON;
> @@ -763,11 +763,7 @@ static int vf610_adc_buffer_predisable(s
>  
>  	writel(hc_cfg, info->regs + VF610_REG_ADC_HC0);
>  
> -	ret = iio_triggered_buffer_predisable(indio_dev);
> -	if (ret)
> -		return ret;
> -
> -	return 0;
> +	return iio_triggered_buffer_predisable(indio_dev);
>  }
>  
>  static const struct iio_buffer_setup_ops iio_triggered_buffer_setup_ops = {
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux