On 20/07/15 18:30, Tirdea, Irina wrote: > > >> -----Original Message----- >> From: Hartmut Knaack [mailto:knaack.h@xxxxxx] >> Sent: 17 July, 2015 11:52 >> To: linux-iio@xxxxxxxxxxxxxxx >> Cc: Jonathan Cameron; Lars-Peter Clausen; Peter Meerwald; Tirdea, Irina; Dogaru, Vlad >> Subject: [PATCH 0/8] bmc150_magn fix and cleanup >> >> Some issues I spotted during review of this driver. First three are quite >> obvious problems, the rest may be matter of taste or intended to stay >> in the original form. Opinions welcome. >> > > Hi Hartmut, > > Thanks for taking the time to cleanup these issues. I know you did not get > to review this code before merge, so I was expecting your feedback :) > > I see Jonathan has already merged some of the changes, so I'm just going > to reply to the rest. > I am fine with the first 4 changes which already got merged anyway. Feel free to offer comments on the rest as well. I was on a bit of a roll and not giving sufficient time to others to review these. The 'obviously' correct are not always so obvious given patch 5! Sorry about that Jonathan > > Thanks, > Irina > >> Hartmut Knaack (8): >> iio:magnetometer:bmc150_magn: add regmap dependency >> iio:magnetometer:bmc150_magn: sort entry alphabetically >> iio:magnetometer:bmc150_magn: output intended variable >> iio:magnetometer:bmc150_magn: replace magic value >> iio:magnetometer:bmc150_magn: add error handling on gpio probe >> iio:magnetometer:bmc150_magn: protect runtime_resume with mutex >> iio:magnetometer:bmc150_magn: expand mutex in trigger_handler >> iio:magnetometer:bmc150_magn: use descriptive name for mask >> >> drivers/iio/magnetometer/Kconfig | 32 ++++++++++++++++++-------------- >> drivers/iio/magnetometer/Makefile | 3 +-- >> drivers/iio/magnetometer/bmc150_magn.c | 31 ++++++++++++++++++++++--------- >> 3 files changed, 41 insertions(+), 25 deletions(-) >> >> -- >> 2.4.3 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
