Some issues I spotted during review of this driver. First three are quite obvious problems, the rest may be matter of taste or intended to stay in the original form. Opinions welcome. Hartmut Knaack (8): iio:magnetometer:bmc150_magn: add regmap dependency iio:magnetometer:bmc150_magn: sort entry alphabetically iio:magnetometer:bmc150_magn: output intended variable iio:magnetometer:bmc150_magn: replace magic value iio:magnetometer:bmc150_magn: add error handling on gpio probe iio:magnetometer:bmc150_magn: protect runtime_resume with mutex iio:magnetometer:bmc150_magn: expand mutex in trigger_handler iio:magnetometer:bmc150_magn: use descriptive name for mask drivers/iio/magnetometer/Kconfig | 32 ++++++++++++++++++-------------- drivers/iio/magnetometer/Makefile | 3 +-- drivers/iio/magnetometer/bmc150_magn.c | 31 ++++++++++++++++++++++--------- 3 files changed, 41 insertions(+), 25 deletions(-) -- 2.4.3 -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html