Re: [PATCH 6/7] iio:light:cm3323: make use of GENMASK

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Peter Meerwald schrieb am 17.06.2015 um 00:29:
> 
>> Use GENMASK to define the integration time bitmask.
> 
> Nack, should be GENMASK(6, 4) I think

Thanks, you are totally right. Seems like I wasn't in the
best shape for coding yesterday. Will fix this and actually
double check this series for other issues.
Thanks,

Hartmut

>  
>> Signed-off-by: Hartmut Knaack <knaack.h@xxxxxx>
>> ---
>>  drivers/iio/light/cm3323.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/iio/light/cm3323.c b/drivers/iio/light/cm3323.c
>> index 6bb75e7..4f362d5 100644
>> --- a/drivers/iio/light/cm3323.c
>> +++ b/drivers/iio/light/cm3323.c
>> @@ -29,7 +29,7 @@
>>  
>>  #define CM3323_CONF_SD_BIT	BIT(0) /* sensor disable */
>>  #define CM3323_CONF_AF_BIT	BIT(1) /* auto/manual force mode */
>> -#define CM3323_CONF_IT_MASK	(BIT(4) | BIT(5) | BIT(6))
>> +#define CM3323_CONF_IT_MASK	GENMASK(4, 6)
>>  #define CM3323_CONF_IT_SHIFT	4
>>  
>>  #define CM3323_INT_TIME_AVAILABLE "0.04 0.08 0.16 0.32 0.64 1.28"
>>
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux