On 13/05/15 15:04, Lars-Peter Clausen wrote:
> While more verbose error messages are useful for debugging we should really
> not put those error messages into the kernel log for normal errors that are
> already reported to the application via the error code, when running in
> non-debug mode.
>
> Otherwise application authors might expect that this is part of the ABI and
> to get the error they should scan the kernel log. Which would be rather
> error prone itself since there is no direct mapping between a operation and
> the error message so it is impossible to find out which error message
> belongs to which error.
Let's just hope no one is using these already!
>
> Signed-off-by: Lars-Peter Clausen <lars@xxxxxxxxxx>
Applied to the togreg branch of iio.git, initially pushed out as testing (etc etc).
> ---
> drivers/iio/industrialio-buffer.c | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/iio/industrialio-buffer.c b/drivers/iio/industrialio-buffer.c
> index df919f4..1f91031 100644
> --- a/drivers/iio/industrialio-buffer.c
> +++ b/drivers/iio/industrialio-buffer.c
> @@ -663,7 +663,7 @@ static int __iio_update_buffers(struct iio_dev *indio_dev,
> if (indio_dev->setup_ops->preenable) {
> ret = indio_dev->setup_ops->preenable(indio_dev);
> if (ret) {
> - printk(KERN_ERR
> + dev_dbg(&indio_dev->dev,
> "Buffer not started: buffer preenable failed (%d)\n", ret);
> goto error_remove_inserted;
> }
> @@ -677,7 +677,7 @@ static int __iio_update_buffers(struct iio_dev *indio_dev,
> if (buffer->access->request_update) {
> ret = buffer->access->request_update(buffer);
> if (ret) {
> - printk(KERN_INFO
> + dev_dbg(&indio_dev->dev,
> "Buffer not started: buffer parameter update failed (%d)\n", ret);
> goto error_run_postdisable;
> }
> @@ -688,7 +688,9 @@ static int __iio_update_buffers(struct iio_dev *indio_dev,
> ->update_scan_mode(indio_dev,
> indio_dev->active_scan_mask);
> if (ret < 0) {
> - printk(KERN_INFO "Buffer not started: update scan mode failed (%d)\n", ret);
> + dev_dbg(&indio_dev->dev,
> + "Buffer not started: update scan mode failed (%d)\n",
> + ret);
> goto error_run_postdisable;
> }
> }
> @@ -702,7 +704,7 @@ static int __iio_update_buffers(struct iio_dev *indio_dev,
> } else { /* Should never be reached */
> /* Can only occur on first buffer */
> if (indio_dev->modes & INDIO_BUFFER_TRIGGERED)
> - pr_info("Buffer not started: no trigger\n");
> + dev_dbg(&indio_dev->dev, "Buffer not started: no trigger\n");
> ret = -EINVAL;
> goto error_run_postdisable;
> }
> @@ -710,7 +712,7 @@ static int __iio_update_buffers(struct iio_dev *indio_dev,
> if (indio_dev->setup_ops->postenable) {
> ret = indio_dev->setup_ops->postenable(indio_dev);
> if (ret) {
> - printk(KERN_INFO
> + dev_dbg(&indio_dev->dev,
> "Buffer not started: postenable failed (%d)\n", ret);
> indio_dev->currentmode = INDIO_DIRECT_MODE;
> if (indio_dev->setup_ops->postdisable)
>
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
